New Plenum component DropdownWithMultiSelect #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DerekAgility
force-pushed
the
dlo/dropdownwithmultiselect
branch
from
45f4e94 to
e3259c4
Compare
DerekAgility
force-pushed
the
dlo/dropdownwithmultiselect
branch
from
ae13f38 to
cdba677
Compare
DerekAgility
commented
Dec 19, 2024
| @@ -19,7 +19,7 @@ jobs: | |||
| - name: Set up Node.js | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: "18" # Specify the Node.js version you want | |||
| node-version: "20" # Specify the Node.js version you want | |||
There was a problem hiding this comment.
bumping these up to match manager app repo
DerekAgility
commented
Dec 19, 2024
Comment on lines
+30
to
+32
| truncateLabel?: boolean; | ||
| /** Full width label */ | ||
| fullWidthLabel?: boolean; |
There was a problem hiding this comment.
just passing these down from the new component to inputlabel
DerekAgility
commented
Dec 19, 2024
| import { Combobox as HeadlessUICombobox } from "@headlessui/react" | ||
| import InputLabel from "@/stories/molecules/inputs/InputLabel" | ||
| import { DynamicIcon } from "@/stories/atoms/icons" | ||
| import { useState, useEffect } from "react"; |
There was a problem hiding this comment.
These are ts fixes that had to be done since we upgraded node
DakotahGodfrey
approved these changes
Dec 19, 2024
DakotahGodfrey
approved these changes
Dec 19, 2024
|
Awesome LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://agilitycms.atlassian.net/browse/FE-2385
Added a new Plenum component that acts like a select, but when the dropdown opens, we show a list of checkboxes.